Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dgpu for codec when dual gpu case #87

Open
wants to merge 1 commit into
base: celadon/u/mr0/master
Choose a base branch
from

Conversation

chenyanxzhu
Copy link

Tracked-On: OAM-128384

Copy link

@feijiang1 feijiang1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are too much useless space change, please remove them

Copy link

@feijiang1 feijiang1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add more description for the pr, for example:
dGPU kernel driver normally is loaded after iGPU kernel driver, then the second i915 device is for dGPU. To make more robust, need double check if the device is dGPU by check the device id or check if local memory exist, currently it seems not needed and difficult to maintain.

dGPU kernel driver normally is loaded after iGPU kernel driver, then
the second i915 device is for dGPU. (Things will be different with
'drmGetDevices2' func, which may return different order. )

TODO:
- Make more robust, need double check if the device is dGPU
 by check the device id or check if local memory exist. currently
 it seems not needed and difficult to maintain.

Tracked-On: OAM-128384
Signed-off-by: chenyanxzhu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Build Not Started Engineering Build Not Started Pending Developer Approval Pending Developer Approval Pending PR Review Pending PR Review Valid commit message
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants